search

nasaharvest / crop-mask

End-to-end workflow for generating high resolution cropland maps
Apache License 2.0
95 stars 28 forks source link

Intercomparison covermaps #228

Closed adamy03 closed 11 months ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ivanzvonkov commented 1 year ago

@adamy03 let me know if you have any questions about any of my comments about the notebook

ivanzvonkov commented 1 year ago

Could you address some of the pre-commit linting failures which are visible if you click "Details": https://results.pre-commit.ci/run/github/324755397/1678902480.NNQY7OIuRS2amcjO41mB8A

image
hannah-rae commented 1 year ago

Thanks for making these changes @adamy03! It looks good to me. Will send thoughts on sampleRegions vs. reduceRegions on slack, but otherwise I think we can merge this in. @ivanzvonkov what do you think?