nasaharvest / crop-mask

End-to-end workflow for generating high resolution cropland maps
Apache License 2.0
95 stars 28 forks source link

Add Malawi corrective label GEE code #233

Closed MsPixels closed 1 year ago

MsPixels commented 1 year ago

Adding the codes for the corrective labeling App developed in Google Earth Engine

ivanzvonkov commented 1 year ago

This is a great initial version! Before merging I think there can be some updates made to make the script easily adaptable for any region. Specifically this can be done by:

  1. Minimizing the amount of region (e.g. Malawi) specific lines
  2. Putting all the region specific lines at the top where they can be easily modified
  3. Adding comments to indicate what possible values can be used.

My comments on the code will generally be about this ^

Along this thread, the javascript file should be called something more general such as: corrective_labels_GEE_script.js

ivanzvonkov commented 1 year ago

@MsPixels left some comments about this script! I think it looks pretty good and it does the intended job. My main suggestions are more about code quality such as making the code more generalizable and reducing clutter. Let me know if you have any questions.

MsPixels commented 1 year ago

Thank you @ivanzvonkov for your comments. I'll take a look and make the necessary corrections!

MsPixels commented 1 year ago

Awesome, thank you so much!

ivanzvonkov commented 1 year ago

You can go ahead and merge!