nasaharvest / crop-mask

End-to-end workflow for generating high resolution cropland maps
Apache License 2.0
95 stars 28 forks source link

Modify change area notebook to use util functions #245

Closed hannah-rae closed 11 months ago

hannah-rae commented 1 year ago

Modifying the change area estimation notebook to use the same(ish) util functions created for the (single year) area estimation notebook

This requires the following steps:

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

ivanzvonkov commented 1 year ago

Is this ready for review @hannah-rae? First time I see these draft PRs 🤔

ivanzvonkov commented 1 year ago

@hannah-rae should this be closed or on the path to merging? FYI on colab pip install shapely==1.8.5 is required to avoid an cartopy import error

ivanzvonkov commented 1 year ago

@adebowaledaniel Could you clarify what's happened here?

  1. Hannah opened a PR to use some of the new util functions
  2. You updated some of the util functions Is this correct?
adebowaledaniel commented 1 year ago

Yes, @ivanzvonkov, It updated the following:

Some tasks still need to be completed for this PR; I plan to review them in the coming week.

  • [ ] Add code for computing area estimates from confusion matrix (was not in notebook previously)
  • [ ] Test by comparing change area estimates for Tigray computed using this notebook and prior analysis (outside repo)
  • [ ] Test by computing change area estimates for new ROI (e.g., Bure or Jimma)

Since the recent changes are needed, especially for single-year area estimation, I will implement them in #212 and merge them.

bhyeh commented 11 months ago

Close w/ merge of #314