nasaharvest / crop-mask

End-to-end workflow for generating high resolution cropland maps
Apache License 2.0
95 stars 28 forks source link

Fix Dataset Dates #305

Closed bhyeh closed 1 year ago

bhyeh commented 1 year ago
  1. Update 2020 corrective Ethiopia Tigray dataset start and end dates (24 months).
  2. Update 2021 Ghent University Ethiopia dataset end date (2022-12-31)
  3. Deleted above datasets from data/datasets and added updated datasets.dvc for regeneration of the two
ivanzvonkov commented 1 year ago

@bhyeh this looks good, please let me know when the datasets have been regenerated and rerun the tests using https://github.com/nasaharvest/crop-mask/wiki/3.-Adding-labeled-data#6-checking-progress-of-the-dataset

bhyeh commented 1 year ago

@bhyeh this looks good, please let me know when the datasets have been regenerated and rerun the tests using https://github.com/nasaharvest/crop-mask/wiki/3.-Adding-labeled-data#6-checking-progress-of-the-dataset

:+1: looks like pipeline is still pipelining. Ghent Ethiopia is done but Ethiopia corrective is still exporting it looks. I'll retrigger again EOD + rerun tests if its completed then.

bhyeh commented 1 year ago

@bhyeh this looks good, please let me know when the datasets have been regenerated and rerun the tests using https://github.com/nasaharvest/crop-mask/wiki/3.-Adding-labeled-data#6-checking-progress-of-the-dataset

👍 looks like pipeline is still pipelining. Ghent Ethiopia is done but Ethiopia corrective is still exporting it looks. I'll retrigger again EOD + rerun tests if its completed then.

Looks like I actually miscalculated the start and end dates for the corrective Ethiopia and added another 12 months. Do you think this will be an issue that would require fixing now?

ivanzvonkov commented 1 year ago

Every time the code for processing a dataset in datasets.py is updated, the respective dataset csv in data/datasets has to be deleted so it's properly regenerated.