search

nasaharvest / crop-mask

End-to-end workflow for generating high resolution cropland maps
Apache License 2.0
95 stars 28 forks source link

Recompute NDVI #306

Closed ivanzvonkov closed 1 year ago

ivanzvonkov commented 1 year ago

Recomputes NDVI when data is loaded.

Demonstration of fix

image
ivanzvonkov commented 1 year ago

Since all old models were trained on incorrect NDVI, the new NDVI values affect the model tests

ivanzvonkov commented 1 year ago

Will retrain all models to ensure model tests pass

ivanzvonkov commented 1 year ago

👍

Maybe we do #307 here to avoid potential merge conflict and otherwise just reduce that work to this PR.

Also retraining on this branch would be dependent on merging #308 first? Edit: neverminded, only if plan to retrain all models with GitHub actions.

Sure I can retrain the corrective labels model here. It'll take some time as it has to be done sequentially

ivanzvonkov commented 1 year ago

@bhyeh based on discussion this is ready for review, let me know if it looks good!