search

nasaharvest / crop-mask

End-to-end workflow for generating high resolution cropland maps
Apache License 2.0
95 stars 28 forks source link

Fixes to area estimation functions #342

Closed hannah-rae closed 8 months ago

hannah-rae commented 8 months ago

This PR fixes a few issues that were breaking the area estimation pipeline in the current main branch

review-notebook-app[bot] commented 8 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

hannah-rae commented 8 months ago

I added the ability to specify the admin2 boundary name instead of just the admin1.

@ivanzvonkov I think you spoke with @bmunsh about the accuracy of different admin boundary layers. Do you think the GADM boundaries ok? I am guessing it's better than NE. We can make the change everywhere from NE to GADM if you think so using this code.

Note I also need to update the integration test to load osgeo in the environment and use the new boundaries.

hannah-rae commented 8 months ago

@ivanzvonkov made the updates we discussed after merging the other PR that updated the intercomparison code.

pre-commit check is failing because it doesn't want me to use bare except; I need to re-create the error to get the specific error code (which results from attempting to sample an area that is out of bounds of the map). I can try to get to that later today but may be tomorrow