nasaharvest / crop-mask

End-to-end workflow for generating high resolution cropland maps
Apache License 2.0
94 stars 26 forks source link

New Sudan data #362

Closed ivanzvonkov closed 5 months ago

ivanzvonkov commented 5 months ago

This PR:

GEE Script snapshot: https://code.earthengine.google.com/2f5d1453e238e6789f64a0fecabcb3eb

Note: Currently exporting the map doesn't work because it's too large. Recommended next step is to either use higher maxPixel parameter or add code to split region in two since middle region is not relevant.

Output:

Screen Shot 2023-11-15 at 3 21 58 PM

Updated intercomparison: https://github.com/nasaharvest/crop-mask/blob/New-Sudan-data/maps/Sudan_Gedaref_Darfur_AlJazirah_2022/intercomparison.ipynb

Issue 1: ROI specified by GEE code does not match sample allocation

@Gedeon-m-gedus GEE code:

var border = ee.FeatureCollection("FAO/GAUL/2015/level1").filter(
  ee.Filter.inList('ADM1_NAME', 
    ['Gadaref', 'Western Darfur', 'Southern Darfur', 'Al Jazeera']
  )
);

Training pts plotted do not fall within boundaries

image

Issue 2: Intercomparison has some bug which duplicates samples A LOT

@hannah-rae

image
review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

ivanzvonkov commented 5 months ago

@Gedeon-m-gedus is it possible to get the ROI from FAO or no?

Gedeon-m-gedus commented 5 months ago

@Gedeon-m-gedus is it possible to get the ROI from FAO or no?

@ivanzvonkov I think the FAO names are kinda different from the names our stakeholders gave. FAO boundaries are different from the real boundaries we want.

ivanzvonkov commented 5 months ago

I have not paid close enough attention with other datasets, investigating duplicates now and will push fix in another PR. @hannah-rae

ivanzvonkov commented 5 months ago

@Gedeon-m-gedus I updated the GEE script to use your provided ROI and some more points are included, however there are still several points in the North East that are not in the ROI. Let me know what you think of this.

Screen Shot 2023-11-16 at 2 22 54 PM
ivanzvonkov commented 5 months ago

Going to merge, can update the ROI in separate PR if need be.