Closed ivanzvonkov closed 3 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@gabrieltseng I am mainly looking for a second look at the Presto benchmarks at the bottom of the notebook, just to make sure everything is setup right.
The presto benchmarks look good to me :)
One note for the encodings - for the Taro mapping, results were better when we concatenated each channel group's embeddings, instead of taking a mean (link, but the code would look slightly different now because of the SRTM updates).
If we are confident that all the channel groups will be present then this might make sense to experiment with (but a drawback is that it makes the encodings quite a bit larger).
Thanks @gabrieltseng, that suggestion definitely seems like the best next step!
Adds a notebook to test different models against the representative test sets in the repository.