nasaharvest / crop-mask

End-to-end workflow for generating high resolution cropland maps
Apache License 2.0
95 stars 28 forks source link

Hyekang #59

Closed joos2010kj closed 2 years ago

ivanzvonkov commented 2 years ago

@joos2010kj Please only add the files which should change for the forecaster training to work. As far as I am aware all the .dvc, .gitignore, data/*, scripts/data files are not necessary for this PR.

ivanzvonkov commented 2 years ago

I think it's good practice with PRs to add a description when possible

ivanzvonkov commented 2 years ago

@joos2010kj I still see all the .dvc files in here

joos2010kj commented 2 years ago

@joos2010kj I still see all the .dvc files in here

@ivanzvonkov Sorry, can you point out where you see it? I don't see any here: https://github.com/nasaharvest/crop-mask/tree/hyekang

ivanzvonkov commented 2 years ago

@joos2010kj I still see all the .dvc files in here

@ivanzvonkov Sorry, can you point out where you see it? I don't see any here: https://github.com/nasaharvest/crop-mask/tree/hyekang

@joos2010kj you've removed them. See https://github.com/nasaharvest/crop-mask/pull/59/files

ivanzvonkov commented 2 years ago

@joos2010kj What works within this branch currently?

joos2010kj commented 2 years ago

@joos2010kj I still see all the .dvc files in here

@ivanzvonkov Sorry, can you point out where you see it? I don't see any here: https://github.com/nasaharvest/crop-mask/tree/hyekang

@joos2010kj you've removed them. See https://github.com/nasaharvest/crop-mask/pull/59/files

Yeah that's what I thought. Then what did you mean by "I still see all the .dvc files in here"?

joos2010kj commented 2 years ago

@joos2010kj What works within this branch currently?

Sorry, could you elaborate on this question? What do you mean by what works?

ivanzvonkov commented 2 years ago

@joos2010kj What works within this branch currently?

Sorry, could you elaborate on this question? What do you mean by what works?

I was wondering about what part the code worked till when you ran the train script, but you answered during the call. All good.