nascarsid / Boolien-Smart-Contracts

0 stars 1 forks source link

`buyItem` and `finalizeBid` function use `HasNFTTransferApproval` #9

Closed mudgen closed 2 years ago

mudgen commented 2 years ago

The HasNFTTransferApproval modifier is used by the addItemToMarket function which is used to add an item to the market.

It is not necessary to use the HasNFTTransferApproval modifier on the buyItem and finalizeBid functions because it is already used on the addItemToMarket function. If token approval is removed then the buyItem and finalizeBid functions will revert. The HasNFTTransferApproval adds gas to functions.