search

nash-io / openlimits

A Rust high performance cryptocurrency trading API with support for multiple exchanges and language wrappers.
http://openlimits.io
BSD 2-Clause "Simplified" License
275 stars 44 forks source link

WebSockets refactoring with callbacks #114

Closed leruaa closed 3 years ago

leruaa commented 3 years ago

Still a WIP for now, but feedback is welcome :)

jankjr commented 3 years ago

I really like this way of interacting with subscriptions.

leruaa commented 3 years ago

I think this is finally ready to be reviewed

Ejhfast commented 3 years ago

Awesome @acatinon, I've been taking a look this evening. It looks great so far, though I'm having some trouble verifying that the Nash subscriptions are working under the callback method. Could just be doing something dumb, will keep playing with it.

leruaa commented 3 years ago

@Ejhfast I'm sure you have more important things to do, I will have a look tonight

leruaa commented 3 years ago

@Ejhfast The Nash WS tests should be ok

Ejhfast commented 3 years ago

Yes, looks good! 🎉 I was doing something dumb, typo in my code. Thanks for updating the tests, all good on my end to merge this.

Can do a later small PR to fix SubscriptionResponseWrapper once the nash client is updated.