nash-io / openlimits

A Rust high performance cryptocurrency trading API with support for multiple exchanges and language wrappers.
http://openlimits.io
BSD 2-Clause "Simplified" License
273 stars 44 forks source link

Add get_account_fees() #173

Open mkazlauskas opened 3 years ago

mkazlauskas commented 3 years ago

172

Implemented for Binance and Coinbase. Didn't find Nash API docs, so for now it will return a not implemented error. I can implement it for Nash if anyone post a link to relevant docs.

I tested this in my personal project for both exchanges (not via cargo test). Not sure how to set up the tests - a lot of tests (including the new tests) failed after adding .env file with my sandbox credentials for Binance.

I'm new to both rust and this project. I'll happily make an required changes.

Note: there are 2 unrelated changes in binance account tests:

notdanilo commented 3 years ago

@mkazlauskas thanks for the PR. I will review it ASAP

notdanilo commented 3 years ago

As a first though: Nash should also be supported. I will check how to do it.

notdanilo commented 3 years ago

nash-rust needs to implement getAccountVolumes, see https://github.com/nash-io/nash-rust/issues/62