Closed leruaa closed 4 years ago
In the openLimits models there are both terminologies (symbol and pair) for the same thing, witch may be confusing.
For instance:
#[derive(Clone, Constructor, Debug)] pub struct Order<T> { pub id: T, pub symbol: String, // <------------------------------------ pub client_order_id: Option<String>, pub created_at: DateTime<Utc>, } #[derive(Clone, Constructor, Debug)] pub struct CancelOrderRequest<T> { pub id: T, pub pair: Option<String>, // <------------------------------------ }
I think it could be harmonized, but which term to choose?
Yes indeed we need to find the terminologies we want to use. There will be a review of all of that when with the code from issue https://github.com/nash-io/openlimits/issues/29
I suggest we use market_pair
market_pair
In the openLimits models there are both terminologies (symbol and pair) for the same thing, witch may be confusing.
For instance:
I think it could be harmonized, but which term to choose?