nash-io / openlimits

A Rust high performance cryptocurrency trading API with support for multiple exchanges and language wrappers.
http://openlimits.io
BSD 2-Clause "Simplified" License
278 stars 44 forks source link

Terminology: symbol vs pair #43

Closed leruaa closed 4 years ago

leruaa commented 4 years ago

In the openLimits models there are both terminologies (symbol and pair) for the same thing, witch may be confusing.

For instance:

#[derive(Clone, Constructor, Debug)]
pub struct Order<T> {
    pub id: T,
    pub symbol: String, // <------------------------------------
    pub client_order_id: Option<String>,
    pub created_at: DateTime<Utc>,
}

#[derive(Clone, Constructor, Debug)]
pub struct CancelOrderRequest<T> {
    pub id: T,
    pub pair: Option<String>, // <------------------------------------
}

I think it could be harmonized, but which term to choose?

ghost commented 4 years ago

Yes indeed we need to find the terminologies we want to use. There will be a review of all of that when with the code from issue https://github.com/nash-io/openlimits/issues/29

ghost commented 4 years ago

I suggest we use market_pair