search

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal
GNU General Public License v3.0
600 stars 113 forks source link

spacemacs-theme-comment-italic changes comment color #104

Closed tx46 closed 6 years ago

tx46 commented 6 years ago

using the light theme, I love the green color of the comments. I also prefer italic comments, but setting spacemacs-theme-comment-italic to t changes the color of the comments. is this a bug?

tx46 commented 6 years ago

any word on this?

nashamri commented 6 years ago

Hello @philiparvidsson sorry my late reply :smile: Yeah I guess this is a bug. Interestingly it doesn't happen with the dark variant of the theme. I'm looking into it now.

nashamri commented 6 years ago

It's a feature!! https://github.com/nashamri/spacemacs-theme/pull/83 lol I completely forgot about this. But I think the colors should be consistent across variants.

tx46 commented 6 years ago

@nashamri what can I do to get the default color but with italicized text?

nashamri commented 6 years ago

yeah, you can add this in your dotspacemacs/user-init:

  (custom-set-variables '(spacemacs-theme-custom-colors
                          '((comment-light . "#2aa1ae"))))
tx46 commented 6 years ago

Thanks!