Improve parens - Githubissues

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal

GNU General Public License v3.0

600 stars 113 forks source link

Improve parens #111

Closed jabranham closed 6 years ago

jabranham commented 6 years ago

show-paren-match and sp-show-pair-match-face should have identical values since they do the same thing
Remove underlining from parens because it looks odd
Theme show-paren-match-expresssion
Theme show-paren-mismatch to better resemble show-paren-match/sp-show-pair-match-face

nashamri commented 6 years ago

Hey @jabranham thanks for this PR, all changes are good :smile:

Just one little thing I'm not sure about, which is removing the underlining of the matching parens since it was like this for long time (no one complained so, people might like it that way :wink:). Maybe if you could just add a variable to toggle this on or off, something like spacemacs-theme-underline-match-parens and the default value is t?

Much appreciated.

jabranham commented 6 years ago

Done, thanks!

On Wed 07 Mar 2018 at 14:14, Nasser Alshammari notifications@github.com wrote:

Hey @jabranham thanks for this PR, all changes are good :smile:

Just one little thing I'm not sure about, which is removing the underlining of the matching parens since it was like this for long time (no one complained so, people might like it that way :wink:). Maybe if you could just add a variable to toggle this on or off, something like spacemacs-theme-underline-match-parens and the default value is t?

Much appreciated.

nashamri commented 6 years ago

Thanks @jabranham :+1: :+1: