Italics for keywords - Githubissues

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal

GNU General Public License v3.0

600 stars 113 forks source link

Italics for keywords #114

Closed thatnerdjosh closed 6 years ago

thatnerdjosh commented 6 years ago

Would it be feasible to add italics option for keywords to support fonts like Dank mono?

I was thinking I could build this out and go off of the changes here https://github.com/nashamri/spacemacs-theme/issues/82

thatnerdjosh commented 6 years ago

@nashamri would this be something there would be interest in merging upstream if built?

nashamri commented 6 years ago

@NerdsvilleCEO Yeah of course, sorry I didn't have the time to work on the theme lately. Hopefully, soon I'll get enough time. I'm always open for PRs.

nashamri commented 6 years ago

@NerdsvilleCEO I just added a new them var spacemacs-theme-keyword-italic that toggles this. It's off by default. So make sure to toggle it on to try it out.

Thanks for this :smile: let me know if you see something wrong.

thatnerdjosh commented 6 years ago

Dang it lol I literally was going to do this today! Beat me to it, but I'm not going to complain :) trying it now!! :))

nashamri commented 6 years ago

lol better luck next time :smile:

thatnerdjosh commented 6 years ago

Hey @nashamri I am having trouble getting this to work in code buffers, keywords don't seem change to italics

nashamri commented 6 years ago

@NerdsvilleCEO Can you show me a screenshot, please?

thatnerdjosh commented 6 years ago

thatnerdjosh commented 6 years ago

comment italics don't work for me either, but if I set font to italic face the chars show as italic

thatnerdjosh commented 6 years ago

thatnerdjosh commented 6 years ago

Hm I noticed something odd, it's as if the comments and keywords aren't italic if I set the font face to italic

nashamri commented 6 years ago

Hmm, can you put the cursor on one of the keywords and press SPC h d c and show me that newly opened buffer?

thatnerdjosh commented 6 years ago

thatnerdjosh commented 6 years ago

I think there must be some mismatch between the variables and the value causing it to always default to false and choose normal slant, must be the naming or something

thatnerdjosh commented 6 years ago

nashamri commented 6 years ago

hmm it's working fine on my end. Recorded a little gif of that. italic-keywords

thatnerdjosh commented 6 years ago

Looks like if I reload the theme it works, is there a way to reload automatically on startup so it registers the config?

nashamri commented 6 years ago

Yeah, just add (setq spacemacs-theme-keyword-italic t) to your dotspacemacs/user-init in your .spacemacs.

screenshot_2018-06-07_18-40-50

thatnerdjosh commented 6 years ago

Alright, thank you so much! 👍

nashamri commented 6 years ago

You are welcomed :smile:

If you are using the customize interface to change options, just make sure you save the canges for future sessions. This video might be helpful: https://www.youtube.com/watch?v=mMcc0IF1hV0

Cheers!