Add support for evil-goggles

syl20bnr commented 6 years ago

I just added evil-goggles, would be cool to have a better color for the flashing effect. Seems not so trivial to add colors for it though: https://github.com/edkolev/evil-goggles/blob/master/evil-goggles.el#L260

nashamri commented 6 years ago

Sure thing

nashamri commented 6 years ago

@syl20bnr It's supported now (https://github.com/nashamri/spacemacs-theme/commit/350221a24d19b8a29dc5c9971b1f5604dda3fecf). However, something seems not right. When I call list-faces-display I get this:

evil-goggles

Which seems okay. But when I use evil-goggles, it seems that only the :background color is applied and not the :foreground. I'm not sure if that's the way it's intended to be or it's some sort of a bug or a conflicting package. Here's my system info for reference:

OS: gnu/linux
Emacs: 25.3.1
Spacemacs: 0.300.0
Spacemacs branch: develop (rev. 769add7c7)
Graphic display: t
Distribution: spacemacs
Editing style: hybrid
Completion: helm

Layers:

(react bibtex auto-completion better-defaults org-page clojure
   (colors :variables colors-enable-rainbow-identifiers nil)
   csv
   (elm :variables elm-fromat-command "elm-format-0.18" elm-format-on-save t elm-sort-imports-on-save t)
   emacs-lisp evil-commentary git github haskell html javascript
   (latex :variables latex-enable-folding t)
   org org-tree-slide org-pdfview pdf-tools
   (python :variables python-auto-set-local-pyenv-version 'on-project-switch python-test-runner 'pytest)
   rcirc
   (shell :variables shell-default-height 30 shell-default-position 'bottom)
   ranger rust markdown
   (mu4e :variables mu4e-installation-path "/usr/share/emacs/site-lisp")
   semantic spell-checking
   (syntax-checking :variables syntax-checking-enable-tooltips nil)
   treemacs writing version-control yaml)

Can you verify this? Once this and this https://github.com/nashamri/spacemacs-theme/issues/114 is done, I'll submit the latest changes upstream :smile:

syl20bnr commented 6 years ago

I had the same behavior until I test with pulse disabled. Seems that pulsing cannot change the foreground color which makes it more annoying than useful. I disabled it by default in Spacemacs so we will have the full contrast with the correct foreground colors.

Thank you for the quick addition! 💜

nashamri commented 6 years ago

Yeah you are right :smile: disabling pulse did solve the problem.

nashamri / spacemacs-theme

Add support for evil-goggles #115