search

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal
GNU General Public License v3.0
600 stars 113 forks source link

diff-hl colors are barely noticeable #118

Closed valignatev closed 6 years ago

valignatev commented 6 years ago

Hi! Thanks for this awesome theme! Maybe it's just me, but diff-hl colors seem to be barely noticeable with the dark theme: image You can only see borders, but not the background. Light theme diff-hl colors are a bit brighter, but I have to really concentrate on them: image

My question is if this is an intended colors (e.g. not a bug).

Also, I've noticed this PR: https://github.com/nashamri/spacemacs-theme/pull/51, which made colors less bright. I've checked how were they before this change: image I agree, this is to much :) But maybe there could be some sane middle ground? What do you think?

nashamri commented 6 years ago

@valignatev Hey, thanks for the kind words :purple_heart: . Yeah I agree, a middle ground solution would be the best thing to go for. There are already brighter variants of the background colors (ending with the -s suffix), so this should be easy. Fixing it now :smile:

nashamri commented 6 years ago

That should do it :smile:

valignatev commented 6 years ago

Wow, that was super fast! Looks perfect now, thanks a lot :heart: