flycheck fringe bitmaps

[valignatev]

Hi! Currently, fringe error/warning bitmaps are not "round", and look like chevrons instead:

I've checked the code, and it seems that spacemacs-theme only defines colors. It means that Spacemacs overrides the bitmap somewhere else, not in the theme. I think that putting it in the theme is a logical thing, because fringe bitmap is a visual thing, and it's in the screenshots in the readme :) What do you think?

[valignatev]

Related spacemacs code for the reference: https://github.com/syl20bnr/spacemacs/blob/bd7ef98e4c35fd87538dd2a81356cc83f5fd02f3/layers/%2Bcheckers/syntax-checking/packages.el#L38

[nashamri]

@valignatev hmm, I'm not sure what's going on here. On my setup it looks as in the screenshots (rounded). I've attached a little screenshot of it: Do you see this on the develop branch?

[valignatev]

Thanks for the fast response! I'm not using Spacemacs, I'm just using this theme with my custom emacs config. And this repo doesn't seem to have a develop branch

[nashamri]

@valignatev Yeah I see, I thought you were using spacemacs, thus the mentioned develop branch :smile:. I'm not sure about this, because if I had this custom fringe indicator in the theme's code, this will be a duplicate of what's already there in spacemacs. Maybe as a middle ground, we can just take that code and put it in the README file of this theme for the users to add it themselves in their configs.

[valignatev]

Yeah, I actually think this is a great way to both avoid duplication and to educate people about Emacs UI capabilities a little bit.

[nashamri]

Awesome, I'll do that once I come back from my holidays. Until then, please let this issue open :smile: :tropical_drink:

[nashamri]

This should solve this issue: ec1283ff8fa10a575e599b7b160e6082f1109409

[valignatev]

Thanks! :tada: