search

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal
GNU General Public License v3.0
600 stars 113 forks source link

Set line-number face unconditionally #125

Closed bmag closed 5 years ago

bmag commented 5 years ago

Fixes a bug with line-number faces originally reported at spacemacs: https://github.com/syl20bnr/spacemacs/issues/10877 Exact details of the bug at https://github.com/syl20bnr/spacemacs/issues/10877#issuecomment-434372597, but in short the code just didn't do what it's supposed to do.

I've opted for removing the when condition, instead of the other proposed solution (two when expressions, one for each face), because it is cleaner. The faces being non-existent in Emacs 25.3 didn't cause any problems for me. Tested by running Spacemacs with modified spacemacs-theme files on Emacs 25.3 and Emacs 26.1.

nashamri commented 5 years ago

@bmag Thanks so much for this, it's been really crazy busy for me lately :smile: I'll check it and merge it tomorrow, hopefully :heart:

nashamri commented 5 years ago

@bmag Thanks for this :+1: yeah I like your solution, I don't think having a non-existing face will cause any issues.