search

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal
GNU General Public License v3.0
600 stars 113 forks source link

Fix ediff-fine-diff-{A, B, C} colors #127

Closed duianto closed 5 years ago

duianto commented 5 years ago

Problem: The current ediff-fine-diff-{A, B, C} colors only inherit from the bold face, this makes it hard to see the fine changes. Solution: Use the same colors as in the diff-refine-{added, changed, removed} faces.

Before

emacs_2018-12-21_16-16-14

After

emacs_2018-12-21_16-15-10

Diff refine colors

emacs_2018-12-21_16-18-13

Notes

The ediff-fine-diff-Ancestor face also inherits from the bold face, but I don't know what command(s) to run to see the ancestor face.

duianto commented 5 years ago

I just remembered that I should have checked the light theme as well.

The red refined text is hard to read.

emacs_2018-12-21_17-20-17

emacs_2018-12-21_17-21-35

nashamri commented 5 years ago

@duianto Hey there :smile: thanks for this :+1: . A little tweak to this before I merge it, if you could update the PR to use ,bg1 instead of ,bg4 as the foreground color, I think this will increase the contrast and will solve the issue with the light version of the theme not being clear.

duianto commented 5 years ago

Yeah that's better:

emacs_2019-01-13_21-44-00

nashamri commented 5 years ago

Great thanks :smile: