search

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal
GNU General Public License v3.0
600 stars 113 forks source link

Unify ediff-current-diff-{A,B,C} background colors #129

Closed duianto closed 5 years ago

duianto commented 5 years ago

Problem: The ediff-current-diff-{A, B} faces use the red-bg-s and green-bg-s colors, but the ediff-current-diff-C face use the non -s, blue-bg colors. Solution: use the blue-bg-s color for the ediff-current-diff-C face.

Before

emacs_2018-12-21_17-44-43 emacs_2018-12-21_17-37-45

After

emacs_2018-12-21_17-43-47 emacs_2018-12-21_17-42-20

nashamri commented 5 years ago

@duianto ummm, I think if we use the none -s variant for all it would make the situation a little better and it might help with the issue you mentioned (#130). I just tried it like so:

     `(ediff-current-diff-A ((,class(:background ,red-bg :foreground ,red))))
     `(ediff-current-diff-B ((,class(:background ,green-bg :foreground ,green))))
     `(ediff-current-diff-C ((,class(:background ,blue-bg :foreground ,blue))))

I think it looks better like this. If you like it too, you can update the PR to merge it :purple_heart:

duianto commented 5 years ago

Yes, that also makes the search highlight more visible.

emacs_2019-01-13_22-10-05

emacs_2019-01-13_22-10-37

duianto commented 5 years ago

I made a typo in the commit message, it should refer to the background "bg" not "fg".

Update: Fixed it!

nashamri commented 5 years ago

Awesome :smile: thanks!