search

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal
GNU General Public License v3.0
600 stars 113 forks source link

search highlight invisible on ediff B (green background) buffer #130

Closed duianto closed 5 years ago

duianto commented 5 years ago

The search highlight is invisible when / searching in an ediff B (green background) buffer.

The / (evil-ex-search-forward) highlight uses the evil-ex-lazy-highlight face, which inherits from the lazy-highlight face, which has the attributes:

           Weight: normal
       Background: #29422d

That's the same color as the ediff-current-diff-B (background) color.

       Foreground: #67b11d
       Background: #29422d

emacs_2018-12-21_18-25-41

There's a PR for changing the ediff C buffers background color: Unify ediff-current-diff-{A,B,C} background colors #129

The search highlight gets even harder to see against the blue background if that PR is accepted.

emacs_2018-12-21_18-30-27

The search highlight color might need to be changed.

duianto commented 5 years ago

The search highlight is now visible against the green background, because the background colors were changed in: Unify ediff-current-diff-{A,B,C} background colors #129