Add support for evil-mc

duianto commented 5 years ago

With the spacemacs-dark theme, the characters on the evil-mc additional cursors are hard to see.

evil-mc support

Reproduction steps

Start Spacemacs on the develop branch (from at least Aug 2018 when the multiple-cursors layer was added)
Open the scratch buffer
Type:
```
test
test
test
test
test
```
With the cursor on one of the words, press grm to create a cursor at the end of all instances.

Notes

Instead of using the same colors for the additional cursors as the active cursor, it would be better if the additional cursors had another color, to make the active cursor clearly visible.

Currently if the active and additional cursors are on space characters then there's no difference between the cursors.

cursors on spaces

The active cursor can be moved between all evil-mc cursors by pressing M-n or M-p.

nashamri commented 5 years ago

All done. Thanks @duianto for your detailed issue report :purple_heart:

duianto commented 5 years ago

It might be better to use a non evil-state color for the fake cursors. Otherwise there might be a risk of confusion whether one is in normal or insert state.

Normal	Insert

These screenshots are probably to short, but if Emacs is maximized and the active cursor is at the top of the screen and a fake cursor is in the middle of the screen, then one might see the green cursor in the middle and think that one is in insert state and start typing.

nashamri commented 5 years ago

@duianto yeah I see what you are saying. Will update it.

nashamri commented 5 years ago

Done with https://github.com/nashamri/spacemacs-theme/commit/c5baa2f12a2e0b306f51977efa43699641b982eb

duianto commented 5 years ago