Improve color support for lsp-mode

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal

GNU General Public License v3.0

605 stars 114 forks source link

Improve color support for lsp-mode #143

Closed rymndhng closed 4 years ago

rymndhng commented 5 years ago

The defaults set by the library are a bit hard on the eyes currently. Notice the yellow font in the top right:

Example: Screen Shot 2019-05-16 at 4 53 59 PM

nashamri commented 5 years ago

Hello @rymndhng it seems like this might be an lsp-mode issue. I might be mistaken as I don't use lsp-mode, but the only faces that this mode defines are:

lsp-face-highlight-read   
lsp-face-highlight-textual
lsp-face-highlight-write  
lsp-lens-face             
lsp-lens-mouse-face

And none of these faces are responsible for that yellow color. Can you please put your point (or cursor :smile: ) on that yellow text in the screenshot and invoke this command M-x describe-char and post the output?

jordanwade90 commented 4 years ago

Most of the lsp-mode faces are defined in the lsp-ui package. That particular face is lsp-ui-sideline-code-action.