search

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal
GNU General Public License v3.0
600 stars 113 forks source link

Button text turns red on mouse click #153

Closed duianto closed 4 years ago

duianto commented 5 years ago

Mouse clicking on the Spacemacs buffers [Update Packages] button, turns the text red.

red color on mouse click spacemacs buffer button

The face seems to be: widget-button-pressed.

widget faces

The button works as expected, but the red color might be interpreted as an error.

error faces

Or as a warning, although most warning faces are orange, except for org-warning which is red.

warning faces

nashamri commented 4 years ago

Thanks @duianto I just fixed this.

duianto commented 4 years ago

That's better than the red color. 👍

This is what it looks like with this fix:

2020-03-23_12-52-33 2020-03-23_12-52-48

In the dark theme, the base text color is different from the color of the other buttons, so it's probably clear that something is going on with that button. But maybe it could be interpreted as if the button having been disabled since it has the same color as the normal text: above ([S P A C E M A C S]) and below (Recent files and Projects) the buttons.

And in the light theme, the base color is quite close to the [Release Notes] and [Search in Spacemacs] text, so it's not clear that the button was just clicked.

Maybe it would be more clear which button was clicked, if it turned green?

     `(widget-button-pressed ((,class (:foreground ,green))))

2020-03-23_13-02-07 2020-03-23_13-01-51

nashamri commented 4 years ago

Yeah that makes sense, I'll update it now, thanks @duianto for your feedback :+1:

nashamri commented 4 years ago

Just amended the previous commit.