Closed mnewt closed 4 years ago
Hello @madalu
I just learned about this, and there is no reason not to implement it :smile: a PR would be appreciated if you want to tackle this.
It probably be as simple as changing https://github.com/nashamri/spacemacs-theme/blob/32ddc1a9b9f4f58ebe8410abc1124b7acf0f36b1/spacemacs-common.el#L195
To:
`(hl-line ((,class (:background ,bg2 :extend t))))
The same goes for the other faces.
@nashamri Great! I'll send a PR shortly
We can close this now, thanks again @mnewt the PR has been merged.
As of a fairly recent Emacs 27.1, faces now require the :extend t property to extend to the end of the line. I'm currently doing this but there are probably others faces that need it set too:
These properties should be added to the themes themselves though. Is there any reason not to go ahead and do this?