search

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal
GNU General Public License v3.0
596 stars 113 forks source link

Add :extend t text-properties to hl-line, region, diff, blocks #156

Closed mnewt closed 4 years ago

mnewt commented 4 years ago

Addresses #155

I changed the faces I know about. There are probably more faces which need the :extend attribute but this should be a good start.

Also, to eliminate the problem (and maybe other problems) in the future, I think it's recommended to set all faces to inherit from the original face and modify it from there, rather than redefining the face. Maybe that approach would also lead to unexpected problems?

nashamri commented 4 years ago

That looks good to me, thanks @mnewt :+1: