Make company tooltip common faces consistent

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal

GNU General Public License v3.0

596 stars 113 forks source link

Make company tooltip common faces consistent #160

Closed ianyepan closed 4 years ago

ianyepan commented 4 years ago

I'm not sure if this is an intentional decision or potentially a bug. But normally (as found in most other modern editors), users would expect the tooltip common faces of candidates to be highlighted whether being selected or not. I find the behaviour to disable the common highlight when the candidate is selected to be inconsistent, and at times, confusing and less expressive. Please keep me updated of your decision, looking forward that this'll be fixed :)

nashamri commented 4 years ago

So sorry for the late reply, and yeah it looks like an oversight on my end :smile: thanks for the PR.

ianyepan commented 4 years ago

@nashamri no problem at all -- thx for merging!