search

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal
GNU General Public License v3.0
596 stars 113 forks source link

[Includes suggested fix]: Ediff highlights rather unreadable #162

Open ianyepan opened 4 years ago

ianyepan commented 4 years ago

Here is a screenshot that showcases the highlights in ediff. Sadly, the high contrast of colours appear to be rather unreadable.

Screenshot 2020-03-22 at 22 26 28

My fix:

I've been experimenting with the colours and decide to use the ones from magit diffs:

(ediff-fine-diff-A        ((t (:background "#663333" :foreground "#eecccc" :extend t))))
(ediff-fine-diff-B        ((t (:background "#336633" :foreground "#cceecc" :extend t))))
(ediff-fine-diff-C        ((t (:background "#333366" :foreground "#ccccee" :extend t))))

Here is the result.

Screenshot 2020-03-22 at 22 25 34

IMHO, this looks a lot more consistent with the design principle of the rest of the colourscheme, and also improves readability of diff hunks.

nashamri commented 4 years ago

Your fix does look much better, I just need to find the time and prepare the alternative set of colors for the light variant. :+1:

ianyepan commented 4 years ago

Absolutely! P.s. Magit does have some good colour choices that might of help :) Thx again for considering the change!