search

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal
GNU General Public License v3.0
596 stars 113 forks source link

[Readability] diff-hl difficult to read #168

Closed ianyepan closed 4 years ago

ianyepan commented 4 years ago

Hi @nashamri thanks for this great theme (again)!

I have noticed that diff-hl (git gutter) is kind of difficult to read. From my experience, many other Emacs themes and modern editors actually make the background of the gutter quite noticeable.

Current Spacemacs theme appearance

Note the faded green and blue gutters on the left fringe (indicating addition and modification)

image

Example reference I: Sublime Text (a popular editor)

The same kind of git gutter style can also be found in Microsoft's Visual Studio and Visual Studio Code.

image

Example reference II: Emacs' doom-themes (a popular theme pack, maintained together with Doom Emacs)

image

My proposal for Spacemacs theme

Light

image

Dark

image

Pull Request

If you agree to the change, I will submit a pull request to improve this issue.

nashamri commented 4 years ago

@ianpan870102 heeey there :smile: This looks great to me and yeah a PR is so welcomed! Thanks for this and I'm so sorry for being late to check it out (life is a bit crazy here :smile:)

ianyepan commented 4 years ago

Hi @nashamri I just created a Pull Request https://github.com/nashamri/spacemacs-theme/pull/169

Thanks for this and I'm so sorry for being late to check it out (life is a bit crazy here 😄)

No problem at all! Hope you're doing well :) Glad to contribute