search

nashamri / spacemacs-theme

Light and dark theme for spacemacs that supports GUI and terminal
GNU General Public License v3.0
600 stars 113 forks source link

Option to enable italics for comments #82

Closed rafaelrinaldi closed 7 years ago

rafaelrinaldi commented 7 years ago

First of all thanks for the theme, I like it a lot.

One thing I miss a lot is comments in italics. I noticed you already have an option to toggle the background color for them and was wondering if there's interest on implementing an option to toggle italics too?

nashamri commented 7 years ago

Thank you @rafaelrinaldi 😄 Yeah I think this is a good idea and can be easily implemented. Will do!

rafaelrinaldi commented 7 years ago

@nashamri I can give it a shot if you would like. I already have it working as a custom configuration.

nashamri commented 7 years ago

Yeah sure, shoot me a pull request and we'll take it from there 👍

ninrod commented 7 years ago

yeah, itallics for comments work well. I did this with my personal fork of spacemacs theme.

nashamri commented 7 years ago

Yes @ninrod, the change is pretty simple. Additonally, I would prefer to have a variable to control this and make it off by default. So something like this:

(defcustom spacemacs-theme-comment-italic nil
  "Make the comment lines italic."
  :type 'boolean
:group 'spacemacs-theme)

And then something like this:

     `(font-lock-comment-face ((,class (
              :slant (when spacemacs-theme-comment-italic italic)
              :foreground ,comment
              :background ,(when spacemacs-theme-comment-bg comment-bg)))))

I did not test this, so if @rafaelrinaldi can try that and send a PR, that would be great 😄

nashamri commented 7 years ago

Fixed in https://github.com/nashamri/spacemacs-theme/commit/11d6958364271e11c920015c24d509f9bdcce6c9

harveyslash commented 6 years ago

very new to spacemacs. can you tell me where to put this option to enable italics in comments ?

rafaelrinaldi commented 6 years ago

@harveyslash You can press ⌘+,. You'll get to the settings panel, then you just search for spacemacs-theme-comment-italic on the search field.

williamJmelton commented 6 years ago

I am still unsure how to make the comments italic. I have placed @nashamri code in my init file but does nothing - I have also tried @rafaelrinaldi suggestion and cannot find spacemacs-theme-comment-italic in the settings page when searching.

rafaelrinaldi commented 6 years ago

It looks like this got removed from the theme options?