nashaofu / xcap

XCap is a cross-platform screen capture library written in Rust. It supports Linux (X11, Wayland), MacOS, and Windows. XCap supports screenshot and video recording (to be implemented).
https://docs.rs/xcap
Apache License 2.0
459 stars 55 forks source link

Error: "Get displays from point failed" on MacOS #113

Closed tpatterson closed 5 months ago

tpatterson commented 5 months ago

This error happens to me when I plug in a second monitor, then arrange the displays so the second monitor appears to the left and above the primary monitor. See the image.

SECONDARY ISSUE: The whole request fails whenever there is an issue returning results for any window in ImplWindow::all(). Instead of failing when one window is unavailable, could xcap instead proceed to return valid results for the other windows that didn't fail? Perhaps by returning a Vec<Option<Window>>

image
tpatterson commented 5 months ago

@nashaofu xcap is great, thank you for making it! I'd be willing to sponsor you more to clean up some bugs and panics.

nashaofu commented 5 months ago

@nashaofu xcap is great, thank you for making it! I'd be willing to sponsor you more to clean up some bugs and panics.

Thank you very much for your sponsorship. I will try to fix it this week

tpatterson commented 5 months ago

@nashaofu xcap is great, thank you for making it! I'd be willing to sponsor you more to clean up some bugs and panics.

Thank you very much for your sponsorship. I will try to fix it this week

Thank you

nashaofu commented 5 months ago

I have fixed this issue, try upgrading to 0.0.6.

tpatterson commented 5 months ago

I confirmed it works, thank you!

tpatterson commented 5 months ago

This also seems to have fixed another issue where the coordinates of windows in were outside the bounds of their monitor. I'll report if I see that issue pop up again. Great work.