#1183 Feat: Modal for selecting the display-type of Product Option and configuring the Storefront view to integrate with the display-type

nashtech-garage / yas

YAS: Yet Another Shop, a sample microservices project in Java

MIT License

1.61k stars 419 forks source link

#1183 Feat: Modal for selecting the display-type of Product Option and configuring the Storefront view to integrate with the display-type #1263

Closed khanhduzz closed 1 week ago

khanhduzz commented 2 weeks ago

Model for customize Product Option in Backoffice and improve Storefront UI

The origin issue: #1183 [Storefront][Product] - Show Product Color Options as colored label instead text name label

Overview:

Add a model in Backoffice when create/update product -> user is able to change the display type of option: color/text; when select display with color, they are also able to pick a specific color.
The Generate Combine button will now generate combinations of multiple different option values together, rather than just a single one.
Configured display Product Combination in Storefront, show color/text based on the selected display type.

Backoffice:

Create product:
Update product:

Screenshot 2024-11-12 094226

Selected Display Type and value:


Select display type	Select display value

Storefront page:

Screenshot 2024-11-05 165658

Screenshot 2024-11-05 165706

github-actions[bot] commented 2 weeks ago

Product Coverage Report

Overall Project	78.16% `-0.04%`	:x:
Files changed	95.45%	:green_apple:

File	Coverage
ProductOptionValueGetVm.java	100%	:green_apple:
ProductPostVm.java	100%	:green_apple:
ProductPutVm.java	100%	:green_apple:
ProductOptionValueDisplay.java	100%	:green_apple:
ProductVariationPutVm.java	100%	:green_apple:
ProductVariationPostVm.java	100%	:green_apple:
ProductService.java	77.99% `-0.1%`	:green_apple:

mochacr0 commented 2 weeks ago

@khanhduzz The product option chips look great. However, the delete button is currently integrated within the chip value, which means clicking anywhere on the chip will remove it. Could we add a separate remove button outside the chip value? This change would help prevent accidental deletions by making the delete action more distinct.

Current: Screenshot 2024-11-08 113217

Propose: Screenshot 2024-11-08 113343

khanhduzz commented 2 weeks ago

Hi @mochacr0, your suggestion to enhance the badges is great, but for now, let's focus solely on functionality. Our website is currently facing issues with product creation and updates. We can create a new ticket to address and improve badge upgrades later. Thanks for your all comments, I will check it out and refactor code for more readable and consistent.