search

nashvillefcc / nashvillefccwebsite

Contains code related to Nashville FCC website
https://www.nashvillefcc.com
MIT License
9 stars 12 forks source link

Header component#47 #56

Closed Hellrungj closed 3 years ago

Hellrungj commented 3 years ago

Finished the styling for Header Component #47.

Hellrungj commented 3 years ago

I think those all are or should be in scope and should be easy to update. I can start working on updating those changes. Thanks for the comments. :+1:

Hellrungj commented 3 years ago

So far so good! I'm going to dive a little deeper tomorrow on resolutions and fonts, but I don't expect I'll find much else to nitpick over. 2 questions:

The logo changes from blue to orange on the About page in the prototype. Is that within scope? The hamburger icon looks slightly different than the one in the prototype. Would you consider that within scope, or prefer dealing with it later?

Update the icon to now update to based on the viewport.

Hellrungj commented 3 years ago

Updated the Icon and removed mentions of mentor night from the project. @MoribundMedium