nasimjamshidi / LAR-IQA

40 stars 2 forks source link

ModuleNotFoundError: No module named 'efficientkan' #1

Closed ghostlyFeng closed 11 hours ago

ghostlyFeng commented 2 months ago

ModuleNotFoundError: No module named 'efficientkan'

Raymondmax commented 2 months ago

@ghostlyFeng you can install it using below command: pip install git+https://github.com/Blealtan/efficient-kan.git

Raymondmax commented 2 months ago

and replace from efficientkan.src.efficient_kan import KAN with from efficient_kan import KAN

nasimjamshidi commented 2 months ago

@Raymondmax, Thanks for the helpful response. I will fix the bugs and update the repo in the next few days. Stay tuned for the update!

ghostlyFeng commented 2 months ago

@Raymondmax Thanks very much. I solved the problem with your method.

han030927 commented 1 week ago

Hi, Just want to make sure whether the efficient kan can reproduce the result of paper. Or something wrong with my implementation. I tryed to import efficient kan from above steps, however, it cannot reporduce the same result from the paper. but the pretrained weight using MLP head is exaclty same as the result in the paper, here's the result i runned locally on UHD-IQA:

  1. validation set :

2 test set:

nasimjamshidi commented 1 week ago

Hi @han030927, Thank you very much for sharing your results with me. I’ve added the LAR-IQA KAN results under the "results" subfolder in the repository. Please let me know if there are any discrepancies compared to your measurements.

I'm also re-running the model to cross-check and better understand the differences, as your results show reasonable correlation (indicating they're not random values) but differ from our main model's outcomes.

Thanks again for reporting it to us, and I’ll get back to you after verifying the released code against our internal version.

nasimjamshidi commented 1 week ago

Hi again @han030927, I checked the code and identified the issue. In the released inference code, we mistakenly applied resizing instead of center cropping for the second transform. I've also updated the weights for the KAN model, which should now give you results that match our model exactly. You now have the CSV file with the results, so you can check a few random images to confirm if the numbers align. Thank you once again for catching that mistake.

han030927 commented 1 week ago

Thanks so much for your quick response! I tried with the new weights, I now can get the exactly same results with the paper. By the way, replacing 'Centercrop' with 'Resize' indeed has impact on the result. Thanks for the good work!

nasimjamshidi commented 5 days ago

You're very welcome! I'm glad to hear the new weights worked for you.