Closed ameily closed 1 year ago
It looks like the Windows tests are failing because they expect the quoted behavior in stdout. If you're ok with my change, I'll update the tests and get them passing.
Hi @ameily, thanks for working on this! If you fix the tests I'd be happy to merge it.
This should be good to go. Thanks for maintaining poe and being responsive! I useit for several Windows and Linux projects.
I found an issue related to #16 where, on Windows, a quoted token is being passed to the command still wrapped in quotes. This only happens on Windows because the
shelx.split(posix=False)
preserves them. You can verify this issue on Windows with the poethepoetytest-quick
task, which passes a quotes string to pytest and fails because the marker contains an invalid quote character:I initially was seeing this with a call to cspell and have reproduced it with a small script / task.
The results of running the
args
task show that, on Windows, the quotes are preserved when they should be stripped.I tried using some of the examples from #16 but I couldn't get them to work in my case, either the glob was being expanded by poe or the quote characters were being passed to the subprocess.