search

nat-n / poethepoet

A task runner that works well with poetry.
https://poethepoet.natn.io/
MIT License
1.4k stars 58 forks source link

Convert included string-form tasks #159

Closed rjaduthie closed 1 year ago

rjaduthie commented 1 year ago

Ensure that the tasks are in the dict-form before trying to assign a "cwd" to the definition.

This is related to issue #158

Sorry no tests for it yet. I'll come back and add those, if you think this fix is worthwhile.

nat-n commented 1 year ago

Hi @rjaduthie, thanks for reporting this bug and proposing a fix.

As you can see I amended your changes to add a failing test and a small refactor to enable a more comprehensive fix. The issue being that normally the default task type (for a task defined as a string) depends on the configured default_task_type, and I wanted to be consistent with this logic. Incidentally I just realised this detail is missing from the docs since I launched the new docs website 😮.

This fix will be included in the next release.