search

nat-n / poethepoet

A task runner that works well with poetry.
https://poethepoet.natn.io/
MIT License
1.45k stars 59 forks source link

Breaking change (`0.21.1` -> `0.22.0`): Unable to reference sibling task files #165

Closed m-roberts closed 1 year ago

m-roberts commented 1 year ago

pyproject.toml

[tool.poe]
include = [
  "tasks/first.toml",
  "tasks/second.toml",
]

tasks/first.toml

[tool.poe.tasks.parent-task]
help = "Run parent task"
sequence = [
  { cmd = "true" },
  "child-task",
]

tasks/second.toml

[tool.poe.tasks.child-task]
help = "Run child task"
cmd = "true"
$ poe parent-task

will now error where it didn't before, as first.toml cannot see second.toml, despite both being included in pyproject.toml.

nat-n commented 1 year ago

Hi @m-roberts, thanks for reporting this. I hadn't considered that use case, so didn't have a test for it, but it makes sense.

It looks like my recent refactor of config loading logic changed the order of validation logic with this unintended consequence. But it should be easy to fix :)

nat-n commented 1 year ago

@m-roberts Shipped a fix in 0.22.1 🚀