envfile on Windows is opened with ANSI code page

nat-n / poethepoet

A task runner that works well with poetry.

https://poethepoet.natn.io/

MIT License

1.39k stars 56 forks source link

envfile on Windows is opened with ANSI code page #176

Closed rockallite closed 9 months ago

rockallite commented 10 months ago

Because the envfile is opened without an explicit encoding, the encoding used is platform-dependent: locale.getencoding() is called to get the current locale encoding, which is ANSI code page on Windows by the way.

So poethepoet will complain about a UTF-8 encoded envfile with non-ASCII characters on Windows. This creates a lot of annoyance. Please fix this, by either allowing the user to specify an encoding for envfile, or opening the envfile with UTF-8 encoding by default. Thank you.

nat-n commented 10 months ago

Hi @rockallite, thanks for the feedback! I'll see about improving this in the next release :)

nat-n commented 9 months ago

Thanks again for reporting this bug. It's now fixed with v0.24.2 🚀