nat-n / poethepoet

A task runner that works well with poetry.
https://poethepoet.natn.io/
MIT License
1.39k stars 56 forks source link

Poe uses different CLI args for working directory than Poetry #212

Closed jeraymond closed 4 months ago

jeraymond commented 4 months ago

Poetry used -C and --directory for the working directory, whereas Poe uses --root. It'd be nice if these were consistent. Would you be open to adding support for -C and --directory in addition to --root for this? If so, I'm happy to contribute a PR.

nat-n commented 4 months ago

Hi @jeraymond,

Thanks for the suggestion. After thinking it over a bit I think you're right, it makes sense to align with this convention (which various unix utils also follow).

I wouldn't want this to be a breaking change, but also wouldn't want the documentation to get noisy, so I'd say the --root option should be deprecated in the sense of being removed from the documentation but still functional for backwards compatibility.

So I'd be happy to receive a PR on this.

nat-n commented 4 months ago

Shipped in 0.26.0 🚀