natalie-lang / natalie_parser

NatalieParser is a zero-dependency, from-scratch, hand-written recursive descent parser for the Ruby Programming Language.
MIT License
63 stars 8 forks source link

Revert "Add lexer support for leading-zero (bare) octal - e.g. 0777" #41

Closed seven1m closed 1 year ago

seven1m commented 1 year ago

Reverts natalie-lang/natalie_parser#40

I merged 40 without looking at the build status. My bad!

seven1m commented 1 year ago

… but this PR fails the build in the same way. 🤔

I will have to investigate further tomorrow!

nanobowers commented 1 year ago

I pulled the master branch and ran rake test and it had 2 test failures out of the box on my system, so I figured it was a system configuration issue on my end. In any event, this PR did not increase/decrease the failures, at least on my end.

seven1m commented 1 year ago

Fixed in 66c8991845302c0222ea6f6f62916f42340b16bb. The RubyParser gem got upgraded and started returning different results for a few things.