search

natanfudge / Not-Enough-Crashes

A mod that makes crashes so pleasant, you can't have enough of them!
MIT License
126 stars 23 forks source link

[Suggestion] Close network connection on crash #188

Open VidTu opened 3 months ago

VidTu commented 3 months ago

Minecraft (client) never does that, so you are still connected, but not "in world". I don't know if it's easy to shut down netty thread from MC main thread, but should be relatively easy to do so. (with try-catching everything of course, some mixin might inject into closing process and cause double crash)

natanfudge commented 3 months ago

It's unlikely I will implement more features myself, but I will accept a PR.

VidTu commented 3 months ago

quite possibly i'll be able to make one in a few days