search

nataniayp / pe

0 stars 0 forks source link

Allow same in-game usernames to be added #5

Open nataniayp opened 2 years ago

nataniayp commented 2 years ago

image.png

image.png

Steps to reproduce:

In this case, both of them have '0' as their usernames in the game named '0'.

In reality, two users having the same in-game username is impossible. The app could have given a warning/error message to the user so that the user can clarify the username and correct it.

nus-pe-bot commented 2 years ago

Team's Response

Result

We are rejecting this bug.

Rationale for rejecting

Our application is made to support multiple competitive games, many of which allow duplicate usernames. Hence, it does not make sense to prevent duplicate usernames as this would remove support for key competitive games.

Rationale for downgrading

We are downgrading this bug to a low. Even if this is a valid feature flaw, it doesn't cause any hindrance to the user. It gives the user more freedom and doesn't prevent the user from providing their desired inputs.

Evidence

Examples: Brawlstars, Minecraft, CSGO, DOTA, etc

(click on link for evidence that competitive games can indeed have non-unique username)

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Lacking validation: Same ingame username allowed

Issue description

Validation of game username is lacking.

Steps to reproduce the issue

  1. Link both users Draco and Tau to the same game ("Valorant") with the same username

What's the expected result?

  • Duplicate username detected

What's the actual result?

  • Having same username is allowed.

Additional details

  • Reason for severity: Many games will have unique usernames. This allows adding of incorrect usernames in a gaming-centered application.

same-game-username.png

[original: nus-cs2103-AY2122S1/pe-interim#1855] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Result

We are rejecting this bug.

Rationale for rejecting

Our application is made to support multiple competitive games, many of which allow duplicate usernames. As mentioned by the tester, many but not all games have unique usernames. Hence, it does not make sense to prevent duplicate usernames as this would remove support for key competitive games.

Rationale for downgrading

We are downgrading this bug to a low. Even if this is a valid feature flaw, it doesn't cause any hindrance to the user. It gives the user more freedom and doesn't prevent the user from providing their desired inputs.

Evidence

Examples: Brawlstars, Minecraft, CSGO, DOTA, etc

(click on link for evidence that competitive games can indeed have non-unique username)

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]