search

natario1 / CameraView

📸 A well documented, high-level Android interface that makes capturing pictures and videos easy, addressing all of the common issues and needs. Real-time filters, gestures, watermarks, frame processing, RAW, output of any size.
https://natario1.github.io/CameraView
Other
4.96k stars 939 forks source link

Update CameraEngine.java #1211

Closed colorgold closed 1 year ago

colorgold commented 1 year ago

FileDesciptor option for API 29+

Solution

I added the FileDescriptor parameter for takeVideoSnapshop functions to take videos with images overlayed. This is the first of 3 pull requests I'm doing because I don't know how to create 1 pull request for all the edits I made.

maxp-hover commented 1 year ago

@colorgold do these PRs enable you to save video snapshots directly to file?

colorgold commented 1 year ago

@colorgold do these PRs enable you to save video snapshots directly to file?

I made some more changes that will help to save the video snapshots directly to the gallery on API 29+, but I was unable to create a pull request because I forgot to to commit the changes on my forked version in Android Studio and not on the original. I believe I have to redo all my changes on the forked version and then create the pull request again. I tested my changes, and they work. I just need to upload the correct files. This is my 1st time doing this, so I was lost. I will probably be able to create the pull request when I get back on Tuesday. Please let me know if there's a better way to submit my changes.