Closed m1r0n41k closed 7 years ago
On my device the demo app is not going through configuration changes when changing orientation. Can you check if this is fixed using this branch? https://github.com/natario1/CameraView/tree/threads
I have same issue when using library and change orientation of device. Device: Meizu M1 Note , Android 4.4.
Demo and threads branch works good.
@DEcSENT do you mean that the threads
branch fixes the issue?
@natario1 Looks like yes. Demo and threads doesn't have this issue. But application is crashed when i add library to new project and rotate device.
Sorry, I mean, have you tried applying the threads
branch to a new project like you say?
@natario1 Well, when i clone this repository and switch to threads branch in demo all works. But i want just import library to new project like "compile 'com.otaliastudios:cameraview:1.2.0'" and use camera. Sorry, if i don't understand something.
It's fine, I just wanted to know if there is a problem in master
(which is like using compile) that was fixed in threads
. If it is so, I will merge threads
and release 1.2.1
.
To add the threads
branch to a new project you should remove the compile line and add a new module pointing to the local cloned repo, after switching to threads
. I'm sure someone can test this, unfortunately I can't reproduce the bug.
@natario1 I did this :) I create new project and create new module (import from cloned repository and switching to threads branch). Now i haven't this issue.
But in landscape orientation i have little trouble - preview is deformate.
Cool, thanks! So I am going to merge threads.
About deformation, did you have this issue with compile 1.2.0
or it appeared now?
@natario1 Yes, have this in both case.
Everything should be fixed in 1.2.1
.
Device: Samsung S6 Android: 5.1.1
Step to reproduce:
Crash: