natashabatalha / PandExo

A Community Tool for Transiting Exoplanet Science with the JWST & HST
https://natashabatalha.github.io/PandExo
GNU General Public License v3.0
34 stars 38 forks source link

Fixes dtype error that breaks the bokeh plot on the Web app results page #65

Closed hover2pi closed 1 year ago

hover2pi commented 2 years ago

Hi @natashabatalha ! For some reason SOSS calculations from PandExo on the ExoCTK server were not able to be displayed even though this does indeed work for the other modes.

This PR fixes that issue by ensuring the x values are float64 instead of float32 before passing it to the plot. Thanks!

hover2pi commented 2 years ago

P.S. no rush on this merge. I am going to fix it on the ExoCTK server manually and then will pull the changes properly once you make a release. Thanks!

hover2pi commented 2 years ago

UPDATE: This fixes things on my machine when I run the Web app on localhost but it hasn't fixed the problem on the ExoCTK server for some reason.

@natashabatalha do you have any idea why SOSS mode calculations might be sending float32 values to the bokeh plots on the results page (and breaking it) while no other mode is having this problem? Any leads or guesses on your part would be greatly appreciated! Thanks!

natashabatalha commented 2 years ago

@hover2pi I cant seem to reproduce the error on my local machine. Can you send me the python environment exoctk is using?

hover2pi commented 2 years ago

Thanks for taking a look @natashabatalha ! Here's the active env:

# packages in environment at /internal/data1/anaconda3/envs/pandexo:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                        main  
_openmp_mutex             4.5                       1_gnu  
alabaster                 0.7.12                   pypi_0    pypi
appdirs                   1.4.4              pyhd3eb1b0_0  
asn1crypto                1.4.0                      py_0  
astropy                   4.1                      pypi_0    pypi
astroquery                0.4.6                    pypi_0    pypi
attrs                     21.4.0             pyhd3eb1b0_0  
babel                     2.10.3                   pypi_0    pypi
backcall                  0.2.0                    pypi_0    pypi
batman-package            2.4.8                    pypi_0    pypi
beautifulsoup4            4.10.0             pyh06a4308_0  
bkcharts                  0.2                      py37_0  
black                     19.10b0                    py_0  
blas                      1.0                         mkl  
bokeh                     0.12.6                   pypi_0    pypi
bottleneck                1.3.4            py37hce1f21e_0  
ca-certificates           2022.3.29            h06a4308_0  
certifi                   2021.10.8        py37h06a4308_2  
cffi                      1.15.0           py37h7f8727e_0  
charset-normalizer        2.0.12                   pypi_0    pypi
click                     8.0.4            py37h06a4308_0  
cloudpickle               1.2.1                      py_0  
coverage                  6.3.2            py37h7f8727e_0  
cryptography              36.0.0           py37h9ce1e76_0  
cycler                    0.11.0             pyhd3eb1b0_0  
cython                    0.29.28          py37h295c915_0  
cytoolz                   0.11.0           py37h7b6447c_0  
d2to1                     0.2.12.post1     py37h28b3542_0  
dask-core                 2.3.0                      py_0  
dbus                      1.13.6               h746ee38_0  
dbus-glib                 0.108                         0    http://ssb.stsci.edu/astroconda
dbus-python               1.2.4                    py37_1    http://ssb.stsci.edu/astroconda
decorator                 5.1.1              pyhd3eb1b0_0  
docutils                  0.18.1                   pypi_0    pypi
entrypoints               0.3                      py37_0  
exoctk                    1.2.3                     dev_0    <develop>
expat                     2.2.6                he6710b0_0  
extension-helpers         1.0.0                    pypi_0    pypi
fftw                      3.3.4                         0    http://ssb.stsci.edu/astroconda
fontconfig                2.13.0               h9420a91_0  
freetype                  2.9.1                h8a8886c_1  
glib                      2.56.2               hd408876_0  
greenlet                  2.0.0a2                  pypi_0    pypi
gst-plugins-base          1.14.0               hbbd80ab_1  
gstreamer                 1.14.0               hb453b48_1  
html5lib                  1.0.1                      py_0  
hypothesis                6.29.3             pyhd3eb1b0_0  
icu                       58.2                 h9c2bf20_1  
idna                      3.3                pyhd3eb1b0_0  
imageio                   2.9.0              pyhd3eb1b0_0  
imagesize                 1.3.0                    pypi_0    pypi
importlib-metadata        4.11.3           py37h06a4308_0  
importlib_metadata        4.11.3               hd3eb1b0_0  
iniconfig                 1.1.1              pyhd3eb1b0_0  
intel-openmp              2019.4                      243  
ipython                   7.34.0                   pypi_0    pypi
jbig                      2.1                           0    https://repo.continuum.io/pkgs/free
jedi                      0.18.1                   pypi_0    pypi
jeepney                   0.7.1              pyhd3eb1b0_0  
jinja2                    3.0.3              pyhd3eb1b0_0  
joblib                    1.1.0                    pypi_0    pypi
jpeg                      9b                            0    https://repo.continuum.io/pkgs/free
jwst-gtvt                 0.2.0                    pypi_0    pypi
keyring                   23.4.0           py37h06a4308_0  
kiwisolver                1.3.2            py37h295c915_0  
libedit                   3.1.20181209         hc058e9b_0  
libffi                    3.2.1                         1    https://repo.continuum.io/pkgs/free
libgcc                    7.2.0                h69d50b8_2  
libgcc-ng                 9.1.0                hdf63c60_0  
libgfortran               3.0.0                         1    https://repo.continuum.io/pkgs/free
libgfortran-ng            7.3.0                hdf63c60_0  
libgomp                   9.3.0               h5101ec6_17  
libiconv                  1.14                          0    https://repo.continuum.io/pkgs/free
libpng                    1.6.37               hbc83047_0  
libstdcxx-ng              9.1.0                hdf63c60_0  
libtiff                   4.0.10               h2733197_2  
libuuid                   1.0.3                h1bed415_2  
libxcb                    1.13                 h1bed415_1  
libxml2                   2.9.9                hea5a465_1  
markupsafe                2.0.1            py37h27cfd23_0  
matplotlib                3.2.1                         0  
matplotlib-base           3.2.1            py37hef1b27d_0  
matplotlib-inline         0.1.3                    pypi_0    pypi
mkl                       2019.4                      243  
mkl-service               2.3.0            py37he8ac12f_0  
mkl_fft                   1.3.0            py37h54f3939_0  
mkl_random                1.1.0            py37hd6b4f25_0  
mpmath                    1.2.1            py37h06a4308_0  
mypy_extensions           0.4.3            py37h06a4308_1  
ncurses                   6.1                  he6710b0_1  
networkx                  2.6.3              pyhd3eb1b0_0  
nose                      1.3.7           pyhd3eb1b0_1008  
numexpr                   2.7.3            py37hb2eb853_0  
numpy                     1.19.2           py37h54aff64_0  
numpy-base                1.19.2           py37hfa32c7d_0  
olefile                   0.46                     py37_0  
openssl                   1.1.1n               h7f8727e_0  
packaging                 21.3               pyhd3eb1b0_0  
pandas                    1.3.5            py37h8c16a72_0  
pandeia-engine            1.6                      pypi_0    pypi
pandexo-engine            1.5.3.1                  pypi_0    pypi
parso                     0.8.3                    pypi_0    pypi
pathspec                  0.7.0                      py_0  
pcre                      8.43                 he6710b0_0  
pexpect                   4.8.0                    pypi_0    pypi
photutils                 1.1.0                    pypi_0    pypi
pickleshare               0.7.5                    pypi_0    pypi
pillow                    6.2.1            py37h34e0f95_0  
pip                       21.2.2           py37h06a4308_0  
pkg-config                0.29.2               h1bed415_8  
pkgconfig                 1.5.5            py37h06a4308_0  
pluggy                    1.0.0            py37h06a4308_1  
prompt-toolkit            3.0.29                   pypi_0    pypi
psutil                    5.8.0            py37h27cfd23_1  
ptyprocess                0.7.0                    pypi_0    pypi
py                        1.11.0             pyhd3eb1b0_0  
pycparser                 2.21               pyhd3eb1b0_0  
pyerfa                    2.0.0.1                  pypi_0    pypi
pyfftw                    0.9.2                    py37_4    http://ssb.stsci.edu/astroconda
pygments                  2.12.0                   pypi_0    pypi
pyparsing                 3.0.4              pyhd3eb1b0_0  
pyqt                      5.6.0            py37h22d08a2_6  
pysynphot                 2.0.0                    pypi_0    pypi
pytest                    7.1.1            py37h06a4308_0  
pytest-arraydiff          0.3              py37hb070fc8_0  
pytest-astropy            0.9.0              pyhd3eb1b0_0  
pytest-astropy-header     0.1.2              pyhd3eb1b0_0  
pytest-cov                3.0.0              pyhd3eb1b0_0  
pytest-doctestplus        0.11.1             pyhd3eb1b0_0  
pytest-filter-subpackage  0.1.1              pyhd3eb1b0_0  
pytest-mock               3.6.1              pyhd3eb1b0_0  
pytest-openfiles          0.5.0              pyhd3eb1b0_0  
pytest-remotedata         0.3.2                    py37_0  
python                    3.7.1                h0371630_7  
python-dateutil           2.8.2              pyhd3eb1b0_0  
pytz                      2022.1                   pypi_0    pypi
pyvo                      1.3                      pypi_0    pypi
pywavelets                1.3.0            py37h7f8727e_0  
pyyaml                    6.0              py37h7f8727e_1  
qt                        5.6.3                h8bf5577_3  
readline                  7.0                  h7b6447c_5  
regex                     2022.3.15        py37h7f8727e_0  
requests                  2.27.1                   pypi_0    pypi
scikit-image              0.19.2           py37h51133e4_0  
scipy                     1.3.1                    pypi_0    pypi
secretstorage             3.3.1            py37h06a4308_0  
setuptools                62.1.0                   pypi_0    pypi
sip                       4.18.1           py37h295c915_2  
six                       1.16.0             pyhd3eb1b0_1  
snowballstemmer           2.2.0                    pypi_0    pypi
sortedcontainers          2.4.0              pyhd3eb1b0_0  
soupsieve                 2.3.1              pyhd3eb1b0_0  
sphinx                    1.5.6                    pypi_0    pypi
sphinx-astropy            0.0.0                    pypi_0    pypi
sqlalchemy                1.4.34                   pypi_0    pypi
sqlite                    3.29.0               h7b6447c_0  
stsci.distutils           0.3.8                    py37_3    http://ssb.stsci.edu/astroconda
stsynphot                 1.1.0                    pypi_0    pypi
svo-filters               0.4.1                    pypi_0    pypi
synphot                   1.1.1                    pypi_0    pypi
tifffile                  2020.10.1        py37hdd07704_2  
tk                        8.6.8                hbc83047_0  
toml                      0.10.2             pyhd3eb1b0_0  
tomli                     1.2.2              pyhd3eb1b0_0  
toolz                     0.10.0                     py_0  
tornado                   6.1              py37h27cfd23_0  
traitlets                 5.3.0                    pypi_0    pypi
twine                     4.0.0                    pypi_0    pypi
typed-ast                 1.4.3            py37h7f8727e_1  
typing_extensions         4.1.1              pyh06a4308_0  
urllib3                   1.26.9                   pypi_0    pypi
wcwidth                   0.2.5                    pypi_0    pypi
webencodings              0.5.1                    py37_1  
werkzeug                  2.1.1                    pypi_0    pypi
wheel                     0.37.1             pyhd3eb1b0_0  
wtforms                   3.0.1                    pypi_0    pypi
xz                        5.2.4                h14c3975_4  
yaml                      0.2.5                h7b6447c_0  
zipp                      3.7.0              pyhd3eb1b0_0  
zlib                      1.2.11                        0    https://repo.continuum.io/pkgs/free
zstd                      1.3.7                h0b5b093_0  
natashabatalha commented 1 year ago

Hey @hover2pi I still haven't been able to reproduce this error. If you want to checkout pandexo 2.0 and dev, please do and let me know if the problem persists! I have updated everything to bokeh 3 and am wondering if that solves the problem.