search

natashabatalha / virga

A Cloud Model for Exoplanets and Brown Dwarfs
https://natashabatalha.github.io/virga/
27 stars 13 forks source link

Feature request to pass do_virtual from top level in picaso to eddysed in virga #22

Closed lcmayor closed 5 months ago

lcmayor commented 3 years ago

Give the ability to pass do_virtual from picaso, i.e. def compute(atmo, directory = None, as_dict = False, og_solver = True, refine_TP = True, analytical_rg = True, do_virtual = True): https://github.com/natashabatalha/virga/blob/303bde6c3b192cb31533d4a437e27b8ee51a6759/virga/justdoit.py#L17

Allows the pass from the compute call to eddysed qc, qt, rg, reff, ndz, qc_path = eddysed(atmo.t_top, atmo.p_top, atmo.t, atmo.p, condensibles, gas_mw, gas_mmr, rho_p , mmw, atmo.g, atmo.kz, atmo.fsed, mh,atmo.sig, do_virtual=do_virtual) https://github.com/natashabatalha/virga/blob/303bde6c3b192cb31533d4a437e27b8ee51a6759/virga/justdoit.py#L89

Which probably should be true for all eddysed keywords: https://github.com/natashabatalha/virga/blob/303bde6c3b192cb31533d4a437e27b8ee51a6759/virga/justdoit.py#L266

natashabatalha commented 5 months ago

Has been done.