search

natashawylie / iviewer

image viewer plugin for jquery
233 stars 97 forks source link

Image Error Callback #35

Closed 67726e closed 12 years ago

67726e commented 12 years ago

I have added an error callback option, onErrorLoad, to the plugin. It simply is binded to onerror for the image.

As an example use case, I use the very large images in the image viewer and display a loading dialog until the image is loaded. In the event the image cannot be loaded, the loading dialog would be displayed permanently and the use would have no idea that there is in fact a problem.

can3p commented 12 years ago

Also, could you remove minified script from the pull request?

67726e commented 12 years ago

Alright, I fixed the indentation to be 4 spaces, I removed the use of $.proxy and switched to using me and reverted to your latest version of the minified script. Please let me know if you require any more changes on my pull request.

can3p commented 12 years ago

Thanks for the patch! I'll make a new release in a few days