natatapron / android-xbmcremote

Automatically exported from code.google.com/p/android-xbmcremote
0 stars 0 forks source link

Force Close in Cover Downloader #237

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Make sure you don't have any hosts.
2. Press 'Download Covers'
3. Press 'Movie Poster' or something else.

What is the expected output? What do you see instead?
Force Close

What version of XBMC Remote are you using?
0.7.0

Which Android device are you using (and which ROM, if custom)?
HTC Magic Android 1.5

Which XBMC revision are you running and on which platform?
-

Please provide any additional information below.
Alternative reproduction 1:
1. Turn of Wifi.
2. Enter Download Covers -> Movie Posters -> FC

Alternative reproduction 2:
Also, if XBMC isn't running and the app trying to connect.
When the Cover downloader screen appears -> hit back button -> FC.

Original issue reported on code.google.com by bolin.andreas@gmail.com on 25 Apr 2010 at 2:47

GoogleCodeExporter commented 9 years ago
This seems to be caused because ProgressThread run() is trying to access 
Hostfactory.host which is null. I've done a quick fix to check for this and it 
will 
stop the FC but maybe a better solution is to disallow cover downloads entirely 
until 
a connection is established? 

FC when hitting back button is also related to the thread being stalled at 
trying to 
connect and cancel() calls mHandlerIn which have not been created. Again a null 
pointer check here will work.

Original comment by lewin....@gmail.com on 1 May 2010 at 3:48

GoogleCodeExporter commented 9 years ago
Indeed, I haven't even thought about this case. Thanks!

Original comment by phree...@gmail.com on 5 May 2010 at 6:49